make ExceptionLog work outside of requests

app/controllers/application_controller.rb

@@ -205,7 +205,7 @@ class ApplicationController < ActionController::Base
       @message = "An unexpected error occurred." if !(Rails.env.development? || CurrentUser.is_admin?) && message == exception.message
 
       WebLogger.log_exception(@exception, expected: @expected)
-      log = ExceptionLog.add(exception, request) unless @expected
+      log = ExceptionLog.add(exception, request: request) unless @expected
       @log_code = log&.code
       render("static/error", status: status, formats: format)
     end

app/jobs/git_job.rb

@@ -5,11 +5,12 @@ class GitJob < ApplicationJob
 
   good_job_control_concurrency_with(perform_limit: 1)
 
-  # used for locking
-  def perform(_identifier, *commands)
+  def perform(identifier, *commands)
     commands.each do |command|
       system!(command)
     end
+  rescue StandardError => e
+    ExceptionLog.add(e, source: "GitJob", identifier: identifier)
   end
 
   private

app/models/exception_log.rb

@@ -3,12 +3,15 @@
 class ExceptionLog < ApplicationRecord
   serialize :extra_params, coder: JSON
 
-  def self.add(exception, request)
+  def self.add(exception, request: nil, source: nil, **extra)
+    source ||= request.present? ? request.filtered_parameters.slice(:controller, :action).values.join("#") : "Unknown"
     extra_params = {
       host:       Socket.gethostname,
-      params:     request.filtered_parameters,
-      referrer:   request.referrer,
-      user_agent: request.user_agent || "",
+      params:     request.try(:filtered_parameters),
+      referrer:   request.try(:referrer),
+      user_agent: request.try(:user_agent) || "",
+      source:     source,
+      **extra,
     }
 
     # Required to unwrap exceptions that occur inside template rendering.
@@ -22,10 +25,10 @@ class ExceptionLog < ApplicationRecord
     end
 
     create!(
-      ip_addr:      request.remote_ip || "0.0.0.0",
+      ip_addr:      request.try(:remote_ip) || "0.0.0.0",
       class_name:   unwrapped_exception.class.name,
       message:      unwrapped_exception.message,
-      trace:        unwrapped_exception.backtrace.join("\n"),
+      trace:        unwrapped_exception.backtrace.try(:join, "\n"),
       code:         SecureRandom.uuid,
       version:      Websites.config.full_version,
       extra_params: extra_params,

app/views/admin/exceptions/index.html.erb

@@ -4,7 +4,7 @@
       <th style="width: 200px">Created At</th>
       <th>Code</th>
       <th style="width: 100px">Commit</th>
-      <th>Controller/Action</th>
+      <th>Source</th>
       <th>Message</th>
       <th>Stacktrace</th>
     </tr>
@@ -15,7 +15,7 @@
         <td><%= compact_time(exception.created_at) %></td>
         <td><%= exception.code %></td>
         <td><%= exception.version.present? ? link_to(exception.version, GitHelper.commit_url(exception.version)) : "Unknown" %></td>
-        <td><%= exception.extra_params.dig("params", "controller") %>/<%= exception.extra_params.dig("params", "action") %></td>
+        <td><%= exception.extra_params["source"] %></td>
         <td><%= truncate(exception.message, length: 50) %></td>
         <td><%= link_to("View", admin_exception_path(exception)) %></td>
       </tr>